From 2134fea87ba392e7f03c4b4e0ccd003cae4224ad Mon Sep 17 00:00:00 2001
From: "micha.jakubowski" <micha.jakubowski@ffwagency.com>
Date: Thu, 20 Mar 2025 08:39:28 +0100
Subject: [PATCH] ISAICP-9563: Code review
---
...y_view_display.node.event.explore_item.yml | 220 -----------------
...ty_view_display.node.news.explore_item.yml | 224 ------------------
tests/features/homepage.feature | 11 +-
3 files changed, 6 insertions(+), 449 deletions(-)
delete mode 100644 config/sync/core.entity_view_display.node.event.explore_item.yml
delete mode 100644 config/sync/core.entity_view_display.node.news.explore_item.yml
diff --git a/config/sync/core.entity_view_display.node.event.explore_item.yml b/config/sync/core.entity_view_display.node.event.explore_item.yml
deleted file mode 100644
index e4c1451416..0000000000
--- a/config/sync/core.entity_view_display.node.event.explore_item.yml
+++ /dev/null
@@ -1,220 +0,0 @@
-uuid: fbd4a53a-faa6-4035-bc12-8e2aea02ccee
-langcode: en
-status: true
-dependencies:
- config:
- - core.entity_view_mode.node.explore_item
- - field.field.node.event.abstract
- - field.field.node.event.field_attachment
- - field.field.node.event.field_comments
- - field.field.node.event.field_event_agenda
- - field.field.node.event.field_event_contact_email
- - field.field.node.event.field_event_coordinates
- - field.field.node.event.field_event_date
- - field.field.node.event.field_event_logo
- - field.field.node.event.field_event_online_location
- - field.field.node.event.field_event_web_url
- - field.field.node.event.field_keywords
- - field.field.node.event.field_location
- - field.field.node.event.field_organisation
- - field.field.node.event.field_organisation_type
- - field.field.node.event.field_paragraphs_body
- - field.field.node.event.field_scope
- - field.field.node.event.field_shared_in
- - field.field.node.event.field_short_title
- - field.field.node.event.field_site_featured
- - field.field.node.event.field_state
- - field.field.node.event.field_topic
- - field.field.node.event.og_audience
- - field.field.node.event.spatial_coverage
- - node.type.event
- module:
- - layout_builder
- - layout_discovery
- - template_suggestion
- - user
-third_party_settings:
- layout_builder:
- enabled: true
- allow_custom: false
- sections:
- -
- layout_id: layout_onecol
- layout_settings:
- label: ''
- context_mapping: { }
- components:
- 5bae9701-073f-4f80-93b0-736bf37b025a:
- uuid: 5bae9701-073f-4f80-93b0-736bf37b025a
- region: content
- configuration:
- id: 'extra_field_block:node:event:read_more'
- label: 'Read more'
- label_display: '0'
- provider: layout_builder
- context_mapping:
- entity: layout_builder.entity
- weight: -6
- additional: { }
- c3a5c5bf-fe80-4a16-9e9d-e217d7f8c162:
- uuid: c3a5c5bf-fe80-4a16-9e9d-e217d7f8c162
- region: content
- configuration:
- id: 'field_block:node:event:field_event_date'
- label: Date
- label_display: '0'
- provider: layout_builder
- context_mapping:
- entity: layout_builder.entity
- view_mode: view_mode
- formatter:
- type: daterange_default
- label: hidden
- settings:
- timezone_override: ''
- format_type: date_only
- from_to: start_date
- separator: '-'
- third_party_settings:
- template_suggestion:
- template_suggestion: ''
- weight: -7
- additional:
- component_attributes:
- block_attributes:
- id: ''
- class: date
- style: ''
- data: ''
- block_title_attributes:
- id: ''
- class: ''
- style: ''
- data: ''
- block_content_attributes:
- id: ''
- class: ''
- style: ''
- data: ''
- 8b7254a6-314d-4b01-8ee1-ff315744af26:
- uuid: 8b7254a6-314d-4b01-8ee1-ff315744af26
- region: content
- configuration:
- id: 'field_block:node:event:abstract'
- label: Abstract
- label_display: '0'
- provider: layout_builder
- context_mapping:
- entity: layout_builder.entity
- view_mode: view_mode
- formatter:
- type: field_fallback_formatter
- label: hidden
- settings:
- main_field_formatter_id: string
- main_field_formatter_settings:
- link_to_entity: false
- fallback_field_id: field_paragraphs_body
- fallback_field_formatter_id: filtered_entity_reference_bundles
- fallback_field_formatter_settings:
- view_mode: tile
- filtered_entity_bundles:
- simple_paragraph: simple_paragraph
- text: text
- trim_length: 200
- trim_chars: ...
- third_party_settings:
- template_suggestion:
- template_suggestion: bare
- weight: -8
- additional:
- component_attributes:
- block_attributes:
- id: ''
- class: explore-item__description
- style: ''
- data: ''
- block_title_attributes:
- id: ''
- class: ''
- style: ''
- data: ''
- block_content_attributes:
- id: ''
- class: ''
- style: ''
- data: ''
- third_party_settings: { }
-id: node.event.explore_item
-targetEntityType: node
-bundle: event
-mode: explore_item
-content:
- flag_like:
- settings: { }
- third_party_settings: { }
- weight: 10
- region: content
- links:
- settings: { }
- third_party_settings: { }
- weight: 0
- region: content
- published_at:
- type: timestamp
- label: hidden
- settings:
- date_format: custom
- custom_date_format: m/d/y
- timezone: ''
- tooltip:
- date_format: ''
- custom_date_format: ''
- time_diff:
- enabled: false
- future_format: '@interval hence'
- past_format: '@interval ago'
- granularity: 2
- refresh: 60
- third_party_settings:
- template_suggestion:
- template_suggestion: ''
- weight: 2
- region: content
- read_more:
- settings: { }
- third_party_settings: { }
- weight: 2
- region: content
-hidden:
- abstract: true
- featured: true
- field_attachment: true
- field_comments: true
- field_event_agenda: true
- field_event_contact_email: true
- field_event_coordinates: true
- field_event_date: true
- field_event_logo: true
- field_event_online_location: true
- field_event_web_url: true
- field_keywords: true
- field_location: true
- field_organisation: true
- field_organisation_type: true
- field_paragraphs_body: true
- field_scope: true
- field_shared_in: true
- field_short_title: true
- field_site_featured: true
- field_state: true
- field_topic: true
- langcode: true
- og_audience: true
- pinned_in: true
- private_message_link: true
- report: true
- search_api_excerpt: true
- share_link: true
- spatial_coverage: true
- visit_count: true
diff --git a/config/sync/core.entity_view_display.node.news.explore_item.yml b/config/sync/core.entity_view_display.node.news.explore_item.yml
deleted file mode 100644
index a8bacc429d..0000000000
--- a/config/sync/core.entity_view_display.node.news.explore_item.yml
+++ /dev/null
@@ -1,224 +0,0 @@
-uuid: 157e0061-8b99-4691-b056-150a69ea8489
-langcode: en
-status: true
-dependencies:
- config:
- - core.entity_view_mode.node.explore_item
- - field.field.node.news.abstract
- - field.field.node.news.field_attachment
- - field.field.node.news.field_comments
- - field.field.node.news.field_keywords
- - field.field.node.news.field_news_headline
- - field.field.node.news.field_news_logo
- - field.field.node.news.field_news_referenced_solution
- - field.field.node.news.field_news_source_url
- - field.field.node.news.field_paragraphs_body
- - field.field.node.news.field_shared_in
- - field.field.node.news.field_site_featured
- - field.field.node.news.field_state
- - field.field.node.news.field_topic
- - field.field.node.news.og_audience
- - field.field.node.news.spatial_coverage
- - node.type.news
- module:
- - field_group
- - layout_builder
- - layout_discovery
- - template_suggestion
- - user
-third_party_settings:
- field_group:
- group_references:
- children:
- - field_news_source_url
- label: References
- parent_name: ''
- region: hidden
- weight: 4
- format_type: html_element
- format_settings:
- classes: ''
- id: ''
- element: div
- show_label: true
- label_element: h3
- attributes: ''
- effect: none
- speed: fast
- layout_builder:
- enabled: true
- allow_custom: false
- sections:
- -
- layout_id: layout_onecol
- layout_settings:
- label: ''
- context_mapping: { }
- components:
- 853719f6-62e6-4f7c-bbb0-88721c6ebba5:
- uuid: 853719f6-62e6-4f7c-bbb0-88721c6ebba5
- region: content
- configuration:
- id: 'field_block:node:news:published_at'
- label_display: '0'
- context_mapping:
- entity: layout_builder.entity
- formatter:
- type: timestamp
- label: hidden
- settings:
- date_format: custom
- custom_date_format: d/m/Y
- timezone: ''
- tooltip:
- date_format: ''
- custom_date_format: ''
- time_diff:
- enabled: false
- future_format: '@interval hence'
- past_format: '@interval ago'
- granularity: 2
- refresh: 60
- third_party_settings:
- template_suggestion:
- template_suggestion: ''
- weight: -7
- additional:
- component_attributes:
- block_attributes:
- id: ''
- class: date
- style: ''
- data: ''
- block_title_attributes:
- id: ''
- class: ''
- style: ''
- data: ''
- block_content_attributes:
- id: ''
- class: ''
- style: ''
- data: ''
- 10c28c1a-03f9-4ac8-a5b8-ed68b2dd4c58:
- uuid: 10c28c1a-03f9-4ac8-a5b8-ed68b2dd4c58
- region: content
- configuration:
- id: 'field_block:node:news:abstract'
- label: Abstract
- label_display: '0'
- provider: layout_builder
- context_mapping:
- entity: layout_builder.entity
- view_mode: view_mode
- formatter:
- type: field_fallback_formatter
- label: hidden
- settings:
- main_field_formatter_id: string
- main_field_formatter_settings:
- link_to_entity: false
- fallback_field_id: field_paragraphs_body
- fallback_field_formatter_id: filtered_entity_reference_bundles
- fallback_field_formatter_settings:
- view_mode: tile
- filtered_entity_bundles:
- simple_paragraph: simple_paragraph
- text: text
- trim_length: 200
- trim_chars: ...
- third_party_settings:
- template_suggestion:
- template_suggestion: ''
- weight: -9
- additional:
- component_attributes:
- block_attributes:
- id: ''
- class: explore-item__description
- style: ''
- data: ''
- block_title_attributes:
- id: ''
- class: ''
- style: ''
- data: ''
- block_content_attributes:
- id: ''
- class: ''
- style: ''
- data: ''
- e9a340ab-04be-4e59-9b31-6bc58f3b1473:
- uuid: e9a340ab-04be-4e59-9b31-6bc58f3b1473
- region: content
- configuration:
- id: 'extra_field_block:node:news:read_more'
- label: 'Read more'
- label_display: '0'
- provider: layout_builder
- context_mapping:
- entity: layout_builder.entity
- weight: -6
- additional: { }
- third_party_settings: { }
-id: node.news.explore_item
-targetEntityType: node
-bundle: news
-mode: explore_item
-content:
- flag_like:
- settings: { }
- third_party_settings: { }
- weight: 10
- region: content
- published_at:
- type: timestamp
- label: hidden
- settings:
- date_format: custom
- custom_date_format: m/d/y
- timezone: ''
- tooltip:
- date_format: ''
- custom_date_format: ''
- time_diff:
- enabled: false
- future_format: '@interval hence'
- past_format: '@interval ago'
- granularity: 2
- refresh: 60
- third_party_settings:
- template_suggestion:
- template_suggestion: ''
- weight: 1
- region: content
- read_more:
- settings: { }
- third_party_settings: { }
- weight: 2
- region: content
-hidden:
- abstract: true
- featured: true
- field_attachment: true
- field_comments: true
- field_keywords: true
- field_news_headline: true
- field_news_logo: true
- field_news_referenced_solution: true
- field_news_source_url: true
- field_paragraphs_body: true
- field_shared_in: true
- field_site_featured: true
- field_state: true
- field_topic: true
- langcode: true
- links: true
- og_audience: true
- pinned_in: true
- private_message_link: true
- report: true
- search_api_excerpt: true
- share_link: true
- spatial_coverage: true
- visit_count: true
diff --git a/tests/features/homepage.feature b/tests/features/homepage.feature
index 29b0f9c5e8..5fd9684f7b 100644
--- a/tests/features/homepage.feature
+++ b/tests/features/homepage.feature
@@ -316,11 +316,6 @@ Feature: Homepage
Then I should be on the advanced search page
And I should see the following facet summary "Collections"
- When I am on the homepage
- And I click "More news"
- Then I should be on the advanced search page
- And I should see the following facet summary "News"
-
# Check archived items.
Given collection content:
| title | state | description | creation date |
@@ -346,3 +341,9 @@ Feature: Homepage
Given I am on the homepage
Then I should see search bar in navbar
And I should see the search bar in homepage's header
+
+ @group-clone
+ Scenario: The /events path redirects to upcoming events page.
+ Given I am on the homepage
+ When I click "More events"
+ Then I should be on "/upcoming-events"
--
GitLab